Skip to content

Tweak publishing setup#2

Merged
Andarist merged 10 commits into
mainfrom
tweak-publish-setup
May 12, 2026
Merged

Tweak publishing setup#2
Andarist merged 10 commits into
mainfrom
tweak-publish-setup

Conversation

@Andarist
Copy link
Copy Markdown
Member

No description provided.

@Andarist Andarist requested a review from bluwy May 12, 2026 09:14
Comment on lines +1 to +2
name: Setup CI
description: Setup CI
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity - why do we need description too? I can't find the docs for this description field

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird one I think. In VS Code, I have the github actions extension (official) installed, which gives nice intellisense and stuff. For some reason it marked the whole file red without the description, so I added it to please it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-version:
description: Node.js version
required: false
default: 24
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea with defaulting to 22 was that our CI should test against the oldest supported version. I assume you have decided it's an overkill here - that's fine with me, I'm just doublechecking

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I figured it's simpler to only test node 24

Comment thread .github/workflows/publish.yml
@Andarist Andarist merged commit 6acc4cc into main May 12, 2026
3 checks passed
@Andarist Andarist deleted the tweak-publish-setup branch May 12, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants